-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading dependencies and related services #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b30618
to
6a40e04
Compare
Github Actions does not perfectly match the TravisCI features, paticularly the `allow_failures'. I have dropped the test execution on ruby-head and jruby, because they were never required and their failures would disrupt the CI pipeline. README.md has also been updated to include the Github Action, instead of the TravisCI one.
This is the only unsupported version which is still listed in the offical Ruby download page, so it seems like a good choice for the required ruby. This eliminates support for v2.5, and I have also it from CI as well.
Remove the Github Actions support for Bundler 1.7.
This runs the `bundle outdated` command with: * --only-explicit * displaying the output * recording the output in tmp/bundle_outdated.txt
Add all versions from 2.6 to 3.2 and head.
6a40e04
to
d195c2d
Compare
The services has been in maintenance mode so long, and I suspect it is just shutdown. So I am removing the badge.
Using the `paambatti/codeclimate-action` which will automatically download and execute the Code Climate test reporter. * https://github.com/paambaati/codeclimate-action * https://github.com/marketplace/actions/code-climate-coverage-action * https://github.com/codeclimate/test-reporter Additionally, I found that the test reporter does not reliably read the simplecov JSON format, even though it will attempt to use it by default. So I have added the lcov formatter, and configured the reporter to use it. * https://github.com/fortissimo1997/simplecov-lcov Finally, the CC_TEST_REPORTER_ID is stored as a repository secret (i.e., `${{ secrets.CC_TEST_REPORTER_ID }}`) and will need to be added before this action will work as expected.
This will run the tests regularly, and help to identify issue with current dependencies.
yads
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'd imagine a major version release since you're upgrading min ruby version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.