Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement proposer #349

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: implement proposer #349

wants to merge 18 commits into from
+1,164 −62

Conversation

fakedev9999
Copy link
Member

@fakedev9999 fakedev9999 commented Jan 27, 2025 •
edited
Loading

Implements a minimal proposer that interfaces with the OPSuccinctDisputeGame implemented in #342 to create a new game if enough blocks have passed to make a proposal on the L1 by calling the factory contract.

You can find the games create in ETH sepolia network: Factory Contract

@fakedev9999 fakedev9999 changed the base branch from main to taehoon/implement-zkfp January 27, 2025 05:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Metric Value
Batch Start 23,199,930
Batch End 23,199,935
Witness Generation (seconds) 58
Execution Duration (seconds) 67
Total Instruction Count 3,228,204,162
Oracle Verify Cycles 419,930,986
Derivation Cycles 2,470,544,707
Block Execution Cycles 192,077,154
Blob Verification Cycles 177,941,790
Total SP1 Gas 0
Number of Blocks 5
Number of Transactions 59
Ethereum Gas Used 8,936,965
Cycles per Block 645,640,832
Cycles per Transaction 54,715,324
Transactions per Block 11
Gas Used per Block 1,787,393
Gas Used per Transaction 151,473
BN Pair Cycles 0
BN Add Cycles 0
BN Mul Cycles 0
KZG Eval Cycles 0
EC Recover Cycles 922,803
P256 Verify Cycles 0

Base automatically changed from taehoon/implement-zkfp to main January 28, 2025 20:26
@fakedev9999 fakedev9999 force-pushed the taehoon/implement-proposer branch from f8eedd1 to b72131f Compare January 29, 2025 05:48
@fakedev9999 fakedev9999 marked this pull request as ready for review January 29, 2025 05:49
@fakedev9999 fakedev9999 requested a review from puma314 January 29, 2025 05:50
puma314
puma314 reviewed Jan 29, 2025
View reviewed changes
proposer/fp/src/main.rs Outdated Show resolved Hide resolved
proposer/fp/src/main.rs Outdated Show resolved Hide resolved
proposer/fp/src/main.rs Outdated Show resolved Hide resolved
@fakedev9999
refac: private key, fetch l2 block number
530d015
@fakedev9999
chore: cargo fmt
10151cf
@fakedev9999
feat: add logic to get last_valid_proposal_block_number
c17e23f
@fakedev9999
chore: make clippy happy
d791775
@fakedev9999
feat(proposer): add feature to resolve unchallenged games
708c7f1
@fakedev9999
chore: remove unused library
61d81bf
@fakedev9999
refac(proposer): fix init of last_valid_proposal_block_number
bea12e7 
Fix to compute output root instead of making `optimism_outputAtBlock`
rpc calls to l2 node since it is very unstable. Frequently getting
`failed to get L2 output at block` error as a response even though
provided l2 node is an archive node.
@fakedev9999
refac(proposer): use struct Config
4535b50
@fakedev9999
refac(proposer): split resolve_unchallenged_games
8ae7d52
@fakedev9999
refac(proposer): add get_last_valid_proposal_block_number
45f3e00
@fakedev9999
refac(proposer): refac create_game
cf47aba
@fakedev9999
feat: handle first game case
fee6158
@fakedev9999
feat: add env to enable/disable game resolution
30312f0
@fakedev9999
fix: create game with computed output root
fe7265b
@fakedev9999
fix(proposer): fix resolution logic
06f0e12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani ratankaliani left review comments

@puma314 puma314 puma314 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fakedev9999 @puma314 @ratankaliani