Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic collections: Creation of a new panel by using local tree modal #562

Merged
merged 12 commits into from
Feb 2, 2025
Merged

Dynamic collections: Creation of a new panel by using local tree modal #562

merged 12 commits into from
Feb 2, 2025

Conversation

orlinmalkja
Copy link
Contributor

This PR aims to accomplish the following goals:

  • Open a new (local) modal when clicking Add Button
  • Create the tree of the provided collections and show in the modal
  • Add a new panel dynamically when either entering a collection url or selecting a tree item

@orlinmalkja orlinmalkja self-assigned this Jan 30, 2025
paulpestov
paulpestov reviewed Jan 30, 2025
View reviewed changes
src/utils/tree.ts Outdated Show resolved Hide resolved
paulpestov
paulpestov reviewed Jan 30, 2025
View reviewed changes
src/store/DataStore.tsx Outdated Show resolved Hide resolved
paulpestov
paulpestov reviewed Jan 31, 2025
View reviewed changes
src/store/DataStore.tsx Outdated Show resolved Hide resolved
paulpestov
paulpestov reviewed Jan 31, 2025
View reviewed changes
src/utils/http.ts Outdated Show resolved Hide resolved
paulpestov
paulpestov reviewed Jan 31, 2025
View reviewed changes
src/components/Tree.tsx Outdated Show resolved Hide resolved
paulpestov
paulpestov reviewed Jan 31, 2025
View reviewed changes
src/components/Tree.tsx Outdated Show resolved Hide resolved
paulpestov
paulpestov reviewed Jan 31, 2025
View reviewed changes
src/components/Tree.tsx Outdated Show resolved Hide resolved
@orlinmalkja
Copy link
Contributor Author

orlinmalkja commented Jan 31, 2025 •
edited
Loading

@paulpestov I have added new commits to address your raised points. Please continue reviewing!

@paulpestov paulpestov merged commit 67b817b into next Feb 2, 2025
2 checks passed
@paulpestov paulpestov deleted the dynamic-collections-v2 branch February 2, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulpestov paulpestov paulpestov approved these changes

Assignees

@orlinmalkja orlinmalkja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orlinmalkja @paulpestov