Feature: aspect ratio control #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, something broke here, at least for multi aspect ratio multi displays. The positioning setting for the fillmode does nothing and you get ONLY exact aspect ratio matches per display, nothing else. Certainly no cropping, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I encountered some weird behavior with fractional scaling:
Aspect ratio isn't calculated right if screen scaled to 150%, probably rounding error, so searching wallpapers for my 16:10 2560x1600 screen was broken.
To fix this I added control boxes instead of calculation with optional extra string for non-default ratios (multiple options supported). It also makes sense to be able chose different aspect ratio and use cropping and/or scaling positioning.