feat: Add TS template #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
force-pushed
the
oscar/ts-template
branch
from
06cbad3 to
d429017
Compare
ospencer
force-pushed
the
oscar/ts-template
branch
from
d429017 to
66afc85
Compare
cohix
reviewed
Feb 13, 2022
| export function run_e(payload: ArrayBuffer, ident: number) { | ||
| // Imports will be injected by the runtime | ||
| // @ts-ignore | ||
| setup(this.imports, ident); |
There was a problem hiding this comment.
Why do the imports need to be passed every time run_e is called?
There was a problem hiding this comment.
That was done just to keep the library setup simple (instead of having separate setup functions for the imports and the ident). It's just doing one assignment, so no real performance hit. We can change that in a future version though.
There was a problem hiding this comment.
Ok, please file an issue for that change
There was a problem hiding this comment.
cohix
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #179