Gather OVN IC resources #888
Conversation
Add following resources to `subctl gather` for OVN IC use case * GatewayRoutes * NonGatewayRoutes Refer submariner-io/enhancements#186 Signed-off-by: Vishal Thapar <[email protected]>
vthapar
requested review from
Jaanki,
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr888/vthapar/gather-ovn-ic |
| @@ -81,3 +81,11 @@ func gatherGlobalEgressIPs(info *Info) { | |||
| func gatherGlobalIngressIPs(info *Info) { | |||
| ResourcesToYAMLFile(info, submarinerv1.SchemeGroupVersion.WithResource("globalingressips"), corev1.NamespaceAll, v1.ListOptions{}) | |||
| } | |||
|
|
|||
| func gatherGatewayRoutes(info *Info) { | |||
| ResourcesToYAMLFile(info, submarinerv1.SchemeGroupVersion.WithResource("gatewayroutes"), corev1.NamespaceAll, v1.ListOptions{}) | |||
There was a problem hiding this comment.
I think these resources are only created in the submariner-operator namespace. So, using NamespaceAll may not be required, but there is no harm as such. @aswinsuryan what do you suggest?
There was a problem hiding this comment.
I went with ALL coz it will help us catch any issues cause dby bugs or users manually creating them in other namespaces. In normal scenarios, it is practically same so data collected will not vary but good to have ALL to catch in case they show up in other namespaces.
There was a problem hiding this comment.
This resource is similar to the endpoints and clusters that the gateway creates. So I think the gather logic can be similar.
|
🤖 Closed branches: [z_pr888/vthapar/gather-ovn-ic] |
Add following resources to
subctl gatherfor OVN IC use caseRefer submariner-io/enhancements#186