Bump to kind 0.20.0 #1297

skitt · 2023-07-03T16:30:14Z

This adds support for Kubernetes 1.28.

Depends on ovn-kubernetes/ovn-kubernetes#4015

submariner-bot · 2023-07-03T16:30:17Z

🤖 Created branch: z_pr1297/skitt/kind-0.20

dfarrell07 · 2023-07-07T18:32:09Z

Deployment (ovn) failed, re-running.

dfarrell07 · 2023-07-10T14:27:37Z

Deployment (ovn) failed again.

dfarrell07 · 2023-07-10T16:45:46Z

Deployment (ovn) failed again, seems to be consistent.

sridhargaddam · 2023-07-28T18:35:02Z

@aswinsuryan the OVN cluster deployment seems to be failing. Do you have any idea of the recent changes in OVN repo?

2023-07-28T12:39:25.4713041Z [cluster2] Deleted nodes: ["cluster2-worker" "cluster2-worker2" "cluster2-control-plane"]
2023-07-28T12:39:25.4713315Z �[36m[12:39:24.909] [dir=shipyard; cl=cluster2; fn=delete_cluster_on_fail]$ return 1�[0m
2023-07-28T12:39:25.4713569Z [cluster2] ERROR: Max attempts reached, failed to run 'provider_create_cluster'!

tpantelis · 2023-08-11T12:59:25Z

The OVN job consistently fails in this PR (oddly with very little output - seems to timeout) but didn't fail in the dependabot bump PR. The difference is that this PR updates the hashes in scripts/shared/lib/clusters_kind.

aswinsuryan · 2023-08-11T15:54:05Z

It may be solved when dfarrell07#55 goes in. The OVN image we use is an old one as it does get update in quay for every PR merged in OVN. With this one we building image with latest code.

tpantelis · 2023-08-11T15:58:49Z

It may be solved when dfarrell07#55 goes in. The OVN image we use is an old one as it does get update in quay for every PR merged in OVN. With this one we building image with latest code.

Ok but does that explain why the same job for #1333 succeeds?

aswinsuryan · 2023-08-15T00:32:22Z

It may be solved when dfarrell07#55 goes in. The OVN image we use is an old one as it does get update in quay for every PR merged in OVN. With this one we building image with latest code.

Ok but does that explain why the same job for #1333 succeeds?

oh that is strange , I would expect it to be same.

tpantelis · 2023-08-15T01:00:09Z

It may be solved when dfarrell07#55 goes in. The OVN image we use is an old one as it does get update in quay for every PR merged in OVN. With this one we building image with latest code.

Ok but does that explain why the same job for #1333 succeeds?

oh that is strange , I would expect it to be same.

This PR also updated the kind version hashes in scripts/shared/lib/clusters_kind so I'm sure that's the reason. So something in the newer version is causing an issue with OVN.

mkolesnik · 2023-08-15T13:17:28Z

Ok but does that explain why the same job for #1333 succeeds?

I might be wrong, but AFAICT the dependabot updates the go dependencies, while this one updated the actual K8s env that gets deployed, hence the first one is fine while this one clearly has some issues with OVN (which might get fixed with Daniel's patch)

It may be solved when dfarrell07#55 goes in. The OVN image we use is an old one as it does get update in quay for every PR merged in OVN. With this one we building image with latest code.

@dfarrell07 maybe based on this info we want to always rebuild the OVN image, not just on IC mode?

dfarrell07 · 2023-08-15T14:53:03Z

Ok but does that explain why the same job for #1333 succeeds?

I might be wrong, but AFAICT the dependabot updates the go dependencies, while this one updated the actual K8s env that gets deployed, hence the first one is fine while this one clearly has some issues with OVN (which might get fixed with Daniel's patch)

It may be solved when dfarrell07#55 goes in. The OVN image we use is an old one as it does get update in quay for every PR merged in OVN. With this one we building image with latest code.

@dfarrell07 maybe based on this info we want to always rebuild the OVN image, not just on IC mode?

Maybe after the OVN IC PR goes in we can rebase this to test it with both the rebuilt and old images.

dfarrell07 · 2023-08-15T15:05:02Z

I think we need an owner to rebase this and resolve the conflicts to see it run with both the rebuilt OVN image and the old one.

tpantelis · 2023-08-15T19:31:51Z

I think we need an owner to rebase this and resolve the conflicts to see it run with both the rebuilt OVN image and the old one.

I rebased but it still fails.

skitt · 2023-08-16T12:20:24Z

Ok but does that explain why the same job for #1333 succeeds?

I might be wrong, but AFAICT the dependabot updates the go dependencies, while this one updated the actual K8s env that gets deployed, hence the first one is fine while this one clearly has some issues with OVN (which might get fixed with Daniel's patch)

Since #1302, the Go dependencies determine the versions of tools we use (the idea being that dependabot then keeps track of updates for us). So #1333 also changes the version of kind deployed in the environment. Without the hash changes however, the k8s images being deployed don’t change. I haven’t checked in detail what the actual changes are, but as a general rule we’re supposed to use the hashes given with each kind release (because images are often rebuilt to handle changes in kind itself).

stale · 2023-09-17T02:55:55Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dfarrell07 · 2023-10-24T13:26:14Z

We're still seeing weirdness with OVN CI (K8s networkplugin doesn't come up).

Jaanki · 2023-11-15T07:56:51Z

@aswinsuryan Can you please take a look at this one on priority. We need it to start testing k8s 1.28.

aswinsuryan · 2023-11-17T01:06:46Z

The ovn-kube-node pod fails to come up due to this error.

2798 ovnkube.go:136] failed to start node network manager: failed to start default node network controller: failed to create IPTablesHelper for proto 0: could not get iptables version: exit status 127

It works fine with 1.26.3 but not with kindest/node:v1.26.6@sha256:6e2d8b28a5b601defe327b98bd1c2d1930b49e5d8c512e1895099e4504007adb. This requires a fix in ovn-kubernetes.

skitt · 2023-11-17T09:38:41Z

@aswinsuryan thanks for the investigation! Do you know what the fix needs to be? I haven’t found a difference between the 1.26.3 and 1.26.6 images which would explain the change in behaviour...

skitt · 2023-11-17T10:07:29Z

Ah, ovn-kubernetes/ovn-kubernetes#4015

github-actions · 2023-11-17T16:46:14Z

This PR/issue depends on:

~~Use /usr/sbin/iptables instead of /sbin/iptables ovn-kubernetes/ovn-kubernetes#4015~~
By Dependent Issues (🤖). Happy coding!

skitt · 2023-11-17T16:59:59Z

I bumped ovn-kubernetes to the tip of the main branch, with the iptables fix, but it’s still failing to deploy (and I’ve run out of time to look into this, I’ll loop back next week unless someone else figures it out).

aswinsuryan · 2023-11-17T23:50:39Z

ll loop back next week unless someone else figures it out).

Now it is failing at,

./daemonset.sh: line 824: openssl: command not found (ovn-kubernetes/dist/images/daemonset.sh)

we use the -ric (run-in-container) option and seems like the container where it runs has the command missing.

Adding this (in scripts/shared/lib/clusters_kind) solves it, but not sure if it is something we want to do

delete_cluster_on_fail ./ovn-kubernetes/contrib/kind.sh -ov "$OVN_IMAGE" -cn "${KIND_CLUSTER_NAME}" -ric "${ovn_flags[@]}" -lr -dd "${KIND_CLUSTER_NAME}.local" --disable-ovnkube-identity

skitt · 2023-11-20T10:07:04Z

Adding this (in scripts/shared/lib/clusters_kind) solves it, but not sure if it is something we want to do

delete_cluster_on_fail ./ovn-kubernetes/contrib/kind.sh -ov "$OVN_IMAGE" -cn "${KIND_CLUSTER_NAME}" -ric "${ovn_flags[@]}" -lr -dd "${KIND_CLUSTER_NAME}.local" --disable-ovnkube-identity

Adding --disable-ovnkube-identity disables https://github.com/ovn-org/ovn-kubernetes/blob/master/docs/node-identity.md which doesn’t seem to be a problem for tests.

This adds support for Kubernetes 1.28. ovn-kubernetes needs to be bumped to a version with support for the new Debian 11-based kind images (iptables is only in /usr/sbin). openssl is no longer available, which causes deployments to fail when trying to set up certificates for node identity; disable that for now (this might be fixed with Debian 12-based images in kind 0.21). Signed-off-by: Stephen Kitt <[email protected]>

submariner-bot · 2023-11-20T10:31:06Z

🤖 Closed branches: [z_pr1297/skitt/kind-0.20]

skitt added the e2e-projects Run E2E tests in each consuming project label Jul 3, 2023

skitt requested review from mkolesnik, Oats87, sridhargaddam and tpantelis as code owners July 3, 2023 16:30

skitt mentioned this pull request Jul 3, 2023

Extend tests to K8s 1.26 and 1.27 submariner-io/submariner-operator#2715

Merged

dfarrell07 approved these changes Jul 3, 2023

View reviewed changes

nyechiel approved these changes Jul 4, 2023

View reviewed changes

sridhargaddam approved these changes Jul 5, 2023

View reviewed changes

tpantelis enabled auto-merge (rebase) July 13, 2023 17:50

skitt mentioned this pull request Jul 24, 2023

Bump to kind 0.19.0 #1303

Closed

tpantelis mentioned this pull request Aug 15, 2023

Bump sigs.k8s.io/kind from 0.18.0 to 0.20.0 in /tools #1333

Closed

mkolesnik approved these changes Aug 15, 2023

View reviewed changes

aswinsuryan mentioned this pull request Aug 15, 2023

Add OVN IC CI #1338

Merged

tpantelis force-pushed the kind-0.20 branch from 0e98052 to 59a69ec Compare August 15, 2023 18:59

tpantelis disabled auto-merge August 15, 2023 19:00

stale bot added the wontfix This will not be worked on label Sep 17, 2023

dfarrell07 removed the wontfix This will not be worked on label Sep 19, 2023

skitt assigned aswinsuryan Oct 17, 2023

skitt force-pushed the kind-0.20 branch 2 times, most recently from 71d8ff8 to 59281f7 Compare November 15, 2023 07:57

github-actions bot added the dependent label Nov 17, 2023

skitt force-pushed the kind-0.20 branch from 59281f7 to 838a113 Compare November 17, 2023 16:45

github-actions bot removed the dependent label Nov 17, 2023

skitt force-pushed the kind-0.20 branch from 838a113 to ab374d9 Compare November 17, 2023 16:46

skitt force-pushed the kind-0.20 branch from ab374d9 to c0c2dfd Compare November 20, 2023 10:08

skitt force-pushed the kind-0.20 branch from c0c2dfd to 71554a4 Compare November 20, 2023 10:09

skitt merged commit 1180650 into submariner-io:devel Nov 20, 2023
53 of 54 checks passed

skitt deleted the kind-0.20 branch November 20, 2023 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump to kind 0.20.0 #1297

Bump to kind 0.20.0 #1297

skitt commented Jul 3, 2023 •

edited

Loading

submariner-bot commented Jul 3, 2023

dfarrell07 commented Jul 7, 2023

dfarrell07 commented Jul 10, 2023

dfarrell07 commented Jul 10, 2023

sridhargaddam commented Jul 28, 2023

tpantelis commented Aug 11, 2023 •

edited

Loading

aswinsuryan commented Aug 11, 2023

tpantelis commented Aug 11, 2023

aswinsuryan commented Aug 15, 2023

tpantelis commented Aug 15, 2023

mkolesnik commented Aug 15, 2023

dfarrell07 commented Aug 15, 2023

dfarrell07 commented Aug 15, 2023

tpantelis commented Aug 15, 2023

skitt commented Aug 16, 2023

stale bot commented Sep 17, 2023

dfarrell07 commented Oct 24, 2023

Jaanki commented Nov 15, 2023

aswinsuryan commented Nov 17, 2023 •

edited

Loading

skitt commented Nov 17, 2023

skitt commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

skitt commented Nov 17, 2023

aswinsuryan commented Nov 17, 2023 •

edited

Loading

skitt commented Nov 20, 2023

submariner-bot commented Nov 20, 2023

Bump to kind 0.20.0 #1297

Bump to kind 0.20.0 #1297

Conversation

skitt commented Jul 3, 2023 • edited Loading

submariner-bot commented Jul 3, 2023

dfarrell07 commented Jul 7, 2023

dfarrell07 commented Jul 10, 2023

dfarrell07 commented Jul 10, 2023

sridhargaddam commented Jul 28, 2023

tpantelis commented Aug 11, 2023 • edited Loading

aswinsuryan commented Aug 11, 2023

tpantelis commented Aug 11, 2023

aswinsuryan commented Aug 15, 2023

tpantelis commented Aug 15, 2023

mkolesnik commented Aug 15, 2023

dfarrell07 commented Aug 15, 2023

dfarrell07 commented Aug 15, 2023

tpantelis commented Aug 15, 2023

skitt commented Aug 16, 2023

stale bot commented Sep 17, 2023

dfarrell07 commented Oct 24, 2023

Jaanki commented Nov 15, 2023

aswinsuryan commented Nov 17, 2023 • edited Loading

skitt commented Nov 17, 2023

skitt commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

skitt commented Nov 17, 2023

aswinsuryan commented Nov 17, 2023 • edited Loading

skitt commented Nov 20, 2023

submariner-bot commented Nov 20, 2023

skitt commented Jul 3, 2023 •

edited

Loading

tpantelis commented Aug 11, 2023 •

edited

Loading

aswinsuryan commented Nov 17, 2023 •

edited

Loading

aswinsuryan commented Nov 17, 2023 •

edited

Loading