Adjust golangci-lint linters #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr1022/tpantelis/update_linters |
skitt
approved these changes
Nov 13, 2024
tpantelis
force-pushed
the
update_linters
branch
from
4561de9 to
f58dd05
Compare
Added new linters (some commented out if not needed) and removed deprecated linters. Related to submariner-io/enhancements#231 Signed-off-by: Tom Pantelis <[email protected]>
The return error must be checked in ToJSON since the exact type is unknown (ie any). Signed-off-by: Tom Pantelis <[email protected]>
Convert to use integer range format. Signed-off-by: Tom Pantelis <[email protected]>
Most of the unnamed params were unused anyway. Signed-off-by: Tom Pantelis <[email protected]>
Use simple concatenation instead. Signed-off-by: Tom Pantelis <[email protected]>
Remove the "nolint" override as "utilruntime.ErrorHandlers" is excluded in the linter config. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
update_linters
branch
from
f58dd05 to
7fcd250
Compare
dfarrell07
approved these changes
Nov 14, 2024
|
The new linters drive some nice refactoring, very cool thanks @tpantelis! |
|
🤖 Closed branches: [z_pr1022/tpantelis/update_linters] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new linters (some commented out if not needed) and removed deprecated linters. Also addressed violations reported by new linters (in separate commits).
Related to submariner-io/enhancements#231