Address perfsprint linter violations

Use simple concatenation instead.

Signed-off-by: Tom Pantelis <[email protected]>

pkg/fake/basic_reactors_test.go

@@ -20,7 +20,6 @@ package fake_test
 
 import (
 	"context"
-	"fmt"
 	"time"
 
 	. "github.com/onsi/ginkgo/v2"
@@ -252,7 +251,7 @@ var _ = Describe("Watch", func() {
 				case watch.Added:
 					Expect(resource.MustToMeta(event.Object).GetName()).To(Equal(t.pod.Name))
 				default:
-					Fail(fmt.Sprintf("Received unexpected watch event: %s", resource.ToJSON(event)))
+					Fail("Received unexpected watch event: " + resource.ToJSON(event))
 				}
 			case <-time.After(1 * time.Second):
 				Fail("Did not receive expected watch event")
@@ -266,7 +265,7 @@ var _ = Describe("Watch", func() {
 
 			select {
 			case event := <-watcher.ResultChan():
-				Fail(fmt.Sprintf("Received unexpected watch event: %s", resource.ToJSON(event)))
+				Fail("Received unexpected watch event: " + resource.ToJSON(event))
 			case <-time.After(300 * time.Millisecond):
 			}
 		})

pkg/resource/rest.go

@@ -22,7 +22,6 @@ import (
 	"context"
 	"crypto/x509"
 	"encoding/base64"
-	"fmt"
 
 	"github.com/pkg/errors"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
@@ -91,7 +90,7 @@ func BuildRestConfigFromData(apiServer, apiServerToken, caData string, tls *rest
 	}
 
 	return &rest.Config{
-		Host:            fmt.Sprintf("https://%s", apiServer),
+		Host:            "https://" + apiServer,
 		TLSClientConfig: *tls,
 		BearerToken:     apiServerToken,
 	}, nil
@@ -107,7 +106,7 @@ func BuildRestConfigFromFiles(apiServer, apiServerTokenFile, caFile string, tls
 	}
 
 	return &rest.Config{
-		Host:            fmt.Sprintf("https://%s", apiServer),
+		Host:            "https://" + apiServer,
 		TLSClientConfig: *tls,
 		BearerTokenFile: apiServerTokenFile,
 	}

pkg/syncer/broker/config.go

@@ -60,9 +60,9 @@ func EnvironmentVariable(setting string) string {
 		}
 	}
 
-	panic(fmt.Sprintf("unknown Broker setting %s", setting))
+	panic("unknown Broker setting: " + setting)
 }
 
 func SecretPath(secretName string) string {
-	return fmt.Sprintf("/run/secrets/submariner.io/%s", secretName)
+	return "/run/secrets/submariner.io/" + secretName
 }

pkg/syncer/broker/syncer.go

@@ -155,7 +155,7 @@ var logger = log.Logger{Logger: logf.Log.WithName("BrokerSyncer")}
 // NewSyncer creates a Syncer that performs bi-directional syncing of resources between a local source and a central broker.
 func NewSyncer(config SyncerConfig) (*Syncer, error) { //nolint:gocritic // Minimal performance hit, we modify our copy
 	if len(config.ResourceConfigs) == 0 {
-		return nil, fmt.Errorf("no resources to sync")
+		return nil, errors.New("no resources to sync")
 	}
 
 	var err error

pkg/watcher/resource_watcher.go

@@ -119,7 +119,7 @@ func New(config *Config) (Interface, error) {
 	var err error
 
 	if len(config.ResourceConfigs) == 0 {
-		return nil, fmt.Errorf("no resources to watch")
+		return nil, errors.New("no resources to watch")
 	}
 
 	restMapper := config.RestMapper