Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small tweaks for Readme page #2367

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

jwortmann
Copy link
Member

  1. When you hover over the badges in the current Readme, the spaces between the buttons are underlined, which looks weird. The cause seems to be that the closing </a> tag is on a new line with indentation, and this indentation will become part of the link.
readme.webm
  1. Updated the label of the "docs" badge with the link target location.

  2. I would expect that when I click on the Discord badge, that it will redirect me to the discord page, and not just scroll the page down a little bit (where it is even unclear where the link points to, because corresponding Discord link is at the bottom of the Readme page, so the anchor will not end up at the top of the browser's viewport). Especially because the label of the badge is "SublimeHQ Discord".

  3. The <br> tag after the badges within the paragraph seems to be useless?

  4. Can we remove the ST3 note at the top of the page? LSP for ST3 is not maintained anymore for a long time already, and ST4 is available for a few years now. Also there is nothing really interesting why you would change to the st3 branch - as a ST3 user you are not able to install the ST4 version from Package Control anyway.


I noticed that there are still some duplicated links (to the docs website), which perhaps are not all necessary. But I didn't change that. Also the Gif could maybe use an update one day.

@rwols rwols merged commit a8abecd into sublimelsp:main Nov 22, 2023
4 checks passed
@jwortmann jwortmann deleted the readme-tweaks branch November 22, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants