Adapt to API changes in LSP 1.28.0 #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
predragnikolic
approved these changes
Jan 21, 2024
|
I would wait for @LDAP to see this PR |
|
There is no need to merge it until when it's time to release new LSP version. Otherwise it can block us from releasing any other changes here, if needed. |
LDAP
requested changes
Jan 22, 2024
LDAP
approved these changes
Jan 23, 2024
|
Just a small heads up I will soon create a LSP release and also a release for LSP-jdtls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to changes (sublimelsp/LSP#2393) in (yet to be released at the time of writing this) LSP 1.28.0.
Mainly updates the code that applies text edits plus some minor import changes to avoid "private" exports.
Warning
The changes need to be released at the same time as the new version of LSP
Resolves #46 (Haven't verified behavior before and after. Not sure if there are some minor behavior changes)