-
-
Notifications
You must be signed in to change notification settings - Fork 32
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Bump required VSCode version to 1.86.1
VSCode 1.86.1 included the Electron 27 update. This comes with Node.js 18.17.1. Ref https://code.visualstudio.com/updates/v1_86 Also, this change removes the Node.js version from the CI testing matrix, following the `engines.node` field in `package.json`.
- Loading branch information
1 parent
2b59af3
commit 987daf7
Showing
5 changed files
with
33 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,37 +11,23 @@ on: | |
|
||
jobs: | ||
test: | ||
name: Test for Stylelint ${{ matrix.stylelint }} on Node.js ${{ matrix.node-version }} and ${{ matrix.os }} | ||
name: Test for Stylelint ${{ matrix.stylelint }} on ${{ matrix.os }} | ||
runs-on: ${{ matrix.os }} | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
node-version: [18] | ||
os: [ubuntu-latest, macos-latest] | ||
os: [ubuntu-latest, macos-latest, windows-latest] | ||
stylelint: [14, 15] | ||
include: | ||
- stylelint: 15 | ||
node-version: 14 # For some reason jest-runner-vscode doesn't work well with Node v18 and Windows. | ||
os: windows-latest | ||
- stylelint: 14 | ||
node-version: 14 # For some reason jest-runner-vscode doesn't work well with Node v18 and Windows. | ||
os: windows-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Use Node.js ${{ matrix.node-version }} | ||
- name: Set up Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
node-version-file: .nvmrc | ||
cache: npm | ||
|
||
# TODO: [email protected] is broken on Windows. See https://github.com/npm/cli/issues/4341 | ||
- name: Workaround for npm installation failure on Node.js 14 and Windows | ||
if: ${{ matrix.node-version == '14' && runner.os == 'Windows' }} | ||
run: npm install --global [email protected] | ||
|
||
- name: Install latest npm | ||
if: ${{ matrix.node-version == '18' }} | ||
run: npm install --global npm@latest | ||
|
||
- name: Install dependencies | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
14.17.6 | ||
18.17.1 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters