Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For review #9

Open
wants to merge 104 commits into
base: for_review
Choose a base branch
from
Open

For review #9

wants to merge 104 commits into from

Conversation

strutive07
Copy link
Owner

@strutive07 strutive07 commented Jan 19, 2020 •
edited
Loading

전체 리뷰라 핵심 파일만 리뷰를 부탁드립니다.

모델 파일

  • model.py

학습 및 inference 관련 utils

  • utils.py

데이터 로드

  • data_loader.py

학습용 파일

  • distributed_train.py
  • train.py
  • test.py

@strutive07
create data loader
a37e5ed
@strutive07
add word2idx, idx2word, tokenizer typo fix
75c0ba4
@strutive07
transformer model implementation. not tested
956fcc5 
just half implementation. i have to run this code after implement data loader and batch tester
@strutive07
fix typo
a65d7e6
@strutive07
fix typo: scaled dot product attention shape typo, Embedding paramete…
54248f1 
…r typo
@strutive07
Update greetings.yml
5aca0b5
@strutive07
fix typo, add training mode to dropout layer
77292e7
@strutive07
add sequence save/load to pickle
8e7eae7
@strutive07
Create utils.py
c691957
@strutive07
Create train.py
888897f
@strutive07
change dir to Relative path
3c6aac7
@strutive07
remove f string to run in python 3.5
f4942c2
@strutive07
move Trainer class to utils
02044fc
@strutive07
fix typo
7c7311e
@strutive07
env install script
d9e7dc5
@strutive07
fix imports
d121fb6
@strutive07
fix imports
d9e8cfc
@strutive07
add distributed training
391e9dc
@strutive07
distributed dataset config
5c755c4
@strutive07
fix typo
a7470b8
@strutive07
add reducemean to distributed loss
b0502bf
@strutive07
disable warning message
5024d3f
@strutive07
add print global batch size
e8fc019
@strutive07
change function to tf.function
7ef9e38
@strutive07
remove tf.function
fb0165b
@strutive07
change loss
1e02598
@strutive07
fix import error
cf8e7fd
@strutive07
Update train.py
55a947d
@strutive07
Update distributed_train.py
b6f3055
@strutive07
Update README.md
e305ddf
@strutive07
sort imports
4b6272d
@strutive07
bleu calculator wrap to python funciton
56d64bb
@strutive07
clean unused imports
8b81080
@strutive07
remove unused variables
98f8a29
@strutive07
solve: File opened without the with statement PTC-W0010
41d5e0d
@strutive07
solve: Unnecessary else / elif PYL-R1705
1b522b7
@strutive07
solve: Unnecessary else / elif PYL-R1705
915400b
@strutive07
reformat model file
a9b396f
@strutive07
solve: Re-defined variable from outer scope PYL-W0621
6b29c8d
@strutive07
convert class name to camelcase
7c9f727
@strutive07
remove unused parameters
54493c4
@strutive07
solve: Module imported but unused PYL-W0611
1cf4f97
@strutive07
solve: Consider using in PYL-R1714
f506400
@strutive07
solve: Trailing comma tuple detected PYL-R1707
f634ae6
@strutive07
solve: Multiple spaces found after operator FLK-E222
87fe30b
@strutive07
solve: Expected 2 blank lines, found 0 FLK-E302
9c73654
@strutive07
remove unused docs
9896785
@strutive07
remove variable name 'input'
aed3b8b
@strutive07
remove variable name 'input'
0e96fef
@strutive07
solve: Blank line contains whitespace FLK-W293
58c68d6
@strutive07
fix too long lines
54ebd5f
@strutive07
add deepsource icon to readme
a8b4fda
@strutive07
change model parameter name
454e3b0
@strutive07
Merge pull request #10 from strutive07/clean_code
d8036f8 
Clean code
@strutive07
add bpe download link to README
b4d88f1
@strutive07
fix: typo in readme
9502c8e
@strutive07
fix: move standard download method
d9d836e
@strutive07
Merge pull request #12 from strutive07/feature/add_bpe_model_file_to_…
fef066d 
…readme

[Feature] add bpe model file to readme
@strutive07
add new line to download links
5011b77
@strutive07
change encoder residual connection error
436c4db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@strutive07