actually run tests with correct versions

stripe · Jan 13, 2025 · 246fd3f · 246fd3f
1 parent a8ebba3
commit 246fd3f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -94,15 +94,21 @@ jobs:
         uses: actions/setup-python@v4
         with:
           python-version: |
-            ${{ matrix.python.version }}
+            # the last in the list is the default; 3.10 is just for running pyright
             3.10
+            ${{ matrix.python.version }}
+
+      - name: "check versions"
+        run: |
+          which python
+          echo $PATH
 
       - uses: stripe/openapi/actions/stripe-mock@master
 
       - name: "Install deps"
         run: just install
       - name: Typecheck with pyright
-        run: just pyright ${{ matrix.python.version }}
+        run: just ci-pyright ${{ matrix.python.version }}
         # Skip typecheking in pypy legs
         if: ${{ !contains(matrix.python.version, 'pypy') }}
 

diff --git a/justfile b/justfile
@@ -23,8 +23,13 @@ mypy:
 lint:
     python -m flake8 --show-source stripe tests setup.py
 
-pyright py_version:
-    pyright --pythonversion {{ py_version }}
+pyright:
+    pyright
+
+# use a specific version for this
+ci-pyright py_version:
+    python{{py_version}} --version
+    python{{py_version}} -m pyright --pythonversion {{ py_version }}
 
 format:
     ruff format . --quiet