Upgrade to kafka-clients 3.4.0 #57
Conversation
This is an enabler for integration with the kroxylicious proxy framework because it depends on kafka-clients too, causing problems at runtime if we try to call the EncryptionModule built against an older kafka-clients. Note: topic-encryption with the vertx-proxy will still requires the proxied Kafka cluster or client to be less that version 3.1.0 because it does not yet work with topic ids in the FetchResponse. Signed-off-by: Robert Young <[email protected]>
The solution to that is to intercept the ApiVersionsResponse, rewriting the version of the fetch api to use something pre-topic id. |
|
@chris-giblin could you take a look? |
|
@robobario Were you able to test these changes with older clients to verify topic encryption with names still works? |
I tested it with the vertx-proxy in front of a 3.4.0 broker, and observed that decryption did not work for a 3.4.0 consumer and did work with a 3.0.2 consumer. Happy to check other combinations (old broker versions) on Monday. |
|
Thanks, testing with 3.0.2 suffices for me to verify the behavior for older versions is unchanged. It is nice that the kafka level has been brought up to a recent level with this PR. Thanks! This change however does necessitate implementing the version interception referred to by Tom, above. This is a good time for me to address #17. OK with me to merge this. |
|
@chris-giblin can you approve in code review so we can merge (you're a https://github.com/strimzi/governance/blob/main/COMPONENT-OWNERS and I'm a maintainer, and we need two such approvals to merge). Thanks! |
|
@tombentley @robobario is there anything stopping this being merged? I know the client is out of date already, but it still makes sense to take this. |
This is an enabler for integration with the kroxylicious proxy framework because it depends on kafka-clients too, causing problems at runtime if we try to call the EncryptionModule built against an older kafka-clients.
Note: topic-encryption with the vertx-proxy will still require the proxied Kafka cluster or client to be less that version 3.1.0 because it does not yet work with topic ids in the FetchResponse (see #17 ).