Initial2 #16
Initial2 #16
Conversation
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
| # Getting started | ||
|
|
||
| Requirements: | ||
| - a Kafka instance, version 2.8.0 or older, which you can configure |
There was a problem hiding this comment.
Where does the 2.8.0 requirement come from? Or is this really a statement about what you've tested?
There was a problem hiding this comment.
Kafka 3.1.0 introduces topic id's to FETCH requests (KIP 516). This version of topic encryption does not support topic id's, rather it performs string-matching to identify topic partitions in protocol messages.
Actually Kafka 3.0 will also work with this release, but 2.8.0 is what is tested.
There was a problem hiding this comment.
I have created an issue to address topic IDs: #17
encmod/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-api</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-core</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.apache.logging.log4j</groupId> | ||
| <artifactId>log4j-slf4j-impl</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
I guess these can be test scoped in this module, and then let the vertx-proxy module pull them in as runtime dependencies.
vertx-proxy/pom.xml
Outdated
| <dependency> | ||
| <groupId>io.strimzi</groupId> | ||
| <artifactId>encmod</artifactId> | ||
| <version>0.0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
This can be ${project.version}?
There was a problem hiding this comment.
Indeed. I just committed it. Thanks.
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
This PR consolidates changes made during the discussion in PR #9 which this PR supersedes