-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#434] feat: added create topic endpoint #929
Conversation
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
…s and tests Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Paolo Patierno <[email protected]>
…arameters set optional Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
…arameters set optional Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Hi @ppatierno, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilkerkocatepe thanks for addressing my comments. I left two more and also I think you should rebase again because you are bringing some changes in the pom.xml which are not related to your PR but commits already merged into main.
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
@ilkerkocatepe thanks for addressing my comments but thinking more on your API proposal I have a more "destructive" one :-) The URL would be just {
"topic_name": "my-new-topic",
"partitions_count": 5,
"replication_factor": 3,
} The above JSON would be extensible in the future, allowing to have a "configs" field for example with a properties map for topic configuration parameters. |
You are absolutely right. Also, it will be proper way according to REST standards. I would like to edit implementation :) |
@ilkerkocatepe great to hear that you are still onboard! My apologies for realising this so late. Thanks for the effort! |
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
…arameters set optional Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
…arameters set optional Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
# Conflicts: # CHANGELOG.md
Signed-off-by: ilkerkocatepe <[email protected]>
Hi again @ppatierno, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intentional that it contains the dpeendency changes etc.?
@ilkerkocatepe as Jakub said you have something which belongs to an already existing commit from here ea03491 |
@ilkerkocatepe we are planning to start releasing bridge 0.31.0 RC1 by the end of the week and it would be great to have this in. Do you think you are able clean this PR (removing the unrelated commit) without opening a new one and copying over the code there? Otherwise I will just merge this . |
This reverts commit ea03491 Signed-off-by: ilkerkocatepe <[email protected]>
Signed-off-by: ilkerkocatepe <[email protected]>
I think I messed up everything and need help :/ |
@ilkerkocatepe I just merged it. Thanks! |
This PR resolves issue #434