Allow "." in the expressions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does the I'll check quickly. |
|
Hey @YaroShkvorets, based on our go parser, I have updated our parser rule. Almost all characters should be accepted now (dot included !) |
|
Great, thanks. |
|
It's released on |
|
Tested, works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antelope chains allow "." in the account names and it's natural to use account names in
blockIndexkeys. However, when using such account names in theblockFilter, the parser fails. The alternative is to use quotes but it's not obvious and not great DX.This PR makes parser accept "." in the expressions.