Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix standalone deployment: listen as tier2 when no ss-client defined #61

Merged
merged 2 commits into from
May 9, 2023
Merged

fix standalone deployment: listen as tier2 when no ss-client defined #61

merged 2 commits into from
May 9, 2023

Conversation

sduchesneau
Copy link
Contributor

FIXED

  • Substreams running without a specific tier2 (with default substreams-client-endpoint=<empty>) will now expose tier2 service sf.substreams.internal.v2.Substreams so it can be used internally.

CHANGED

  • flag substreams-client-endpoint now defaults to empty string, which will make a 'tier1' service act also as a 'tier2', serving its own requests. Make sure that you don't expose sf.substreams.internal.v2.Substreams to the public, via an HTTP-aware firewall.
  • flag substreams-partial-mode-enabled renamed to substreams-tier2

@sduchesneau sduchesneau requested a review from maoueh May 9, 2023 15:24
@sduchesneau
Copy link
Contributor Author

This addresses #60

@sduchesneau sduchesneau merged commit 368e493 into develop May 9, 2023
@sduchesneau sduchesneau deleted the fix/tier2-allinone branch May 9, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maoueh maoueh Awaiting requested review from maoueh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sduchesneau