v1.0.0 firecore binary, new block format (based on anypb) #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganized the block printing functionalities in the code. What used to be as BlockPrinterFunc has been incorporated into the Block interface as a method. This change allows each specific type of Block to control its own printing logic. This code restructuring promotes better encapsulation and cohesion.
The variable 'finalizedBlockNum' in blockpoller has been renamed to 'chainLatestFinalizeBlock' for better clarity and understanding. The change also impacts the 'resolveStartBlock' function arguments and 'Run' function parameters and logging. An extra newline in 'tools_checkmergedbatch.go' has been removed as well.
Updated the saveState function to include error handling for state saving and directory creation. Additionally, log cursor saving details to provide useful information for debugging and monitoring.
Adjusted FireBlockHandler.Init(). Removed an unnecessary space in the printed string.
This change eliminates the use of protobuf for unmarshaling payload in consolereader.go. Instead, we directly assign expected typeUrl and payload value to blockPayload. This significantly simplifies the code, making it easier to understand and maintain.
* commit 7b23ef908c0c2b74863c0558ee7f18eaae431834 Stéphane Duchesneau <[email protected]> Date: Mon Dec 4 14:20:37 2023 -0500 add jitter and longer delay on rate-limiting * commit 3eae369c284a499d8985e53dfd1b76a415b52b31 Frederik Schöll <[email protected]> Date: Mon Nov 20 15:43:36 2023 +0100 Merge pull request #26 from fschoell/feature/pass_x_sf_meta_header pass the x-sf-meta header into the metering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.0.0
This is a major release.
Operators
Important
When upgrading your stack to firehose-core v1.0.0, be sure to upgrade all components simultaneously because the block encapsulation format has changed.
Blocks that are merged using the new merger will not be readable by previous versions.
Added
New binary
firecorewhich can run all firehose components (reader,reader-stdin,merger,relayer,firehose,substreams-tier1|2) in a chain-agnostic way. This is not mandatory (it can still be used as a library) but strongly suggested when possible.Current Limitations on Ethereum:
firehoseapp does not support transforms (filters, header-only --for graph-node compatibility--) so you will want to continue running this app fromfireethsubstreamsapps do not support eth_calls so you will want to continue running them fromfireethreaderdoes not support the block format output by the current geth firehose instrumentation, so you will want to continue running it fromfireethNew BlockPoller library to facilitate the implementation of rpc-poller-based chains, taking care of managing reorgs
Considering that firehose-core is chain-agnostic, it's not aware of the different of the different block types. To be able to use tools around block decoding/printing,
there are two ways to provide the type definition:
--proto-pathflagChanged