fix(json-pack): 🐛 allow emojis in strings

streamich · Dec 10, 2023 · a9744dd · a9744dd
1 parent 94f7441
commit a9744dd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/src/json-pack/resp/RespEncoder.ts b/src/json-pack/resp/RespEncoder.ts
@@ -174,7 +174,7 @@ export class RespEncoder<W extends IWriter & IWriterGrowable = IWriter & IWriter
         (encoding.charCodeAt(2) << 8) + // t
         58, // :
     );
-    writer.ascii(str);
+    writer.utf8(str);
     writer.u16(RESP.RN); // \r\n
   }
 

diff --git a/src/json-pack/resp/__tests__/RespDecoder.spec.ts b/src/json-pack/resp/__tests__/RespDecoder.spec.ts
@@ -18,13 +18,10 @@ const assertCodec = (value: unknown, expected: unknown = value): void => {
 
 describe('strings', () => {
   describe('simple strings', () => {
-    test('empty string', () => {
-      assertCodec('');
-    });
-
-    test('short string', () => {
-      assertCodec('foo bar');
-    });
+    test('empty string', () => assertCodec(''));
+    test('short string', () => assertCodec('foo bar'));
+    test('short string with emoji', () => assertCodec('foo bar🍼'));
+    test('short string with emoji and newline', () => assertCodec('foo bar\n🍼'));
 
     test('simple string with newline', () => {
       assertCodec('foo\nbar');