Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better completions #513

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Better completions #513

merged 5 commits into from
Aug 28, 2024

Conversation

BoostCookie
Copy link
Contributor

Fixes #512

str4d
str4d requested changes Aug 27, 2024
View reviewed changes
Copy link
Owner

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 26ebfbf. Generally LGTM, just a couple of questions about the behaviour of these autocompletions. The suggestion is blocking.

rage/src/bin/rage-keygen/cli.rs Outdated Show resolved Hide resolved
rage/src/bin/rage-mount/cli.rs Show resolved Hide resolved
rage/src/bin/rage/cli.rs Show resolved Hide resolved
@str4d str4d added this to the rage 0.11.0 milestone Aug 27, 2024
@BoostCookie BoostCookie requested a review from str4d August 28, 2024 08:44
@str4d str4d merged commit 51760e3 into str4d:main Aug 28, 2024
9 of 10 checks passed
@chenrui333 chenrui333 mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rage 0.11.0
Development

Successfully merging this pull request may close these issues.

UX: Better shell completions
2 participants
@BoostCookie @str4d