feat(capability): add space to location assertion #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View stack outputs
|
also provides direct access to the delegation
alanshaw
approved these changes
Jan 20, 2025
hannahhoward
pushed a commit
that referenced
this pull request
Jan 30, 2025
🤖 I have created a release *beep* *boop* --- ## [5.2.0](content-claims-v5.1.3...content-claims-v5.2.0) (2025-01-30) ### Features * **capability:** add space to location assertion ([#84](#84)) ([5212b1a](5212b1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Enable parsing and usage of assertions defined here with responses from the indexer service.
Implementation
Add Space DID as an optional field for the AssertLocation
For Discussion
Why ship a change here?
This library contains the best JS definitions of our various assertions. Apart from the missing Space DID, it's the SAME as the assertions defined in go-capabilities.
Currently, JS fetching logic for the indexer does NOT understand assertions, and moreover, the locator for the indexing service in the blob-fetcher uses a non-standard approach of using a parsing validator called 'zod' to parse only location claims.
We should maintain full definitions for our various assertions across languages and those definitions should maintain parity.
Ultimately, they shouldn't live here. Maybe @storacha/capabilities -- i.e. move them to w3up. But that's a problem for another day.