Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gateway authorization based on env #174

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

fforbeck
Copy link
Member

@fforbeck fforbeck commented Dec 20, 2024

In order to create new spaces in Staging or localhost environments we need to configure the w3up-client to authorize the correct gateway service, otherwise, it will default to the Production Storacha Gateway.
This PR implements the logic to create the gateway connection based on the environment variables and passes that connection to the w3up-client.createSpace call, so the correct service is authorized.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Website preview 🔗✨

build log

@fforbeck fforbeck requested a review from Peeja December 20, 2024 15:35
Peeja
Peeja previously requested changes Dec 20, 2024
src/components/SpaceCreator.tsx Outdated Show resolved Hide resolved
src/components/SpaceCreator.tsx Outdated Show resolved Hide resolved
src/components/SpaceCreator.tsx Show resolved Hide resolved
src/components/SpaceCreator.tsx Show resolved Hide resolved
src/components/SpaceCreator.tsx Outdated Show resolved Hide resolved
@fforbeck fforbeck requested a review from Peeja December 20, 2024 17:41
@fforbeck fforbeck dismissed Peeja’s stale review January 7, 2025 18:29

changes implemented

Copy link
Member

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me.

It's 'freeway.dag.haus' not 'w3s.link'?

@fforbeck
Copy link
Member Author

fforbeck commented Jan 7, 2025

LGTM to me.

It's 'freeway.dag.haus' not 'w3s.link'?

That's right. I will update that to use w3s.link instead. Thanks for flagging.

@fforbeck fforbeck force-pushed the fix/authorize-staging-gateway branch from d5dac58 to 78dd52b Compare January 7, 2025 19:34
@fforbeck fforbeck merged commit 0eb122d into main Jan 7, 2025
5 checks passed
@fforbeck fforbeck deleted the fix/authorize-staging-gateway branch January 7, 2025 19:48
fforbeck pushed a commit that referenced this pull request Jan 9, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.17.2](w3console-v1.17.1...w3console-v1.17.2)
(2025-01-09)


### Bug Fixes

* create space ([#173](#173))
([597240f](597240f))
* create space using the latest w3up-client version
([#171](#171))
([600766b](600766b))
* **createSpace:** using the latest w3ui with w3up-client
([#176](#176))
([5194dd2](5194dd2))
* gateway authorization based on env
([#174](#174))
([0eb122d](0eb122d))
* set ipfs gateway url based on env var
([#177](#177))
([1defed6](1defed6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants