-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gateway authorization based on env #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fforbeck
force-pushed
the
fix/authorize-staging-gateway
branch
from
December 20, 2024 15:24
71a15c9
to
dcc33bc
Compare
Website preview 🔗✨ |
fforbeck
force-pushed
the
fix/authorize-staging-gateway
branch
from
December 20, 2024 15:58
dcc33bc
to
77679ad
Compare
Peeja
previously requested changes
Dec 20, 2024
hannahhoward
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me.
It's 'freeway.dag.haus' not 'w3s.link'?
That's right. I will update that to use |
fforbeck
force-pushed
the
fix/authorize-staging-gateway
branch
from
January 7, 2025 19:34
d5dac58
to
78dd52b
Compare
fforbeck
pushed a commit
that referenced
this pull request
Jan 9, 2025
🤖 I have created a release *beep* *boop* --- ## [1.17.2](w3console-v1.17.1...w3console-v1.17.2) (2025-01-09) ### Bug Fixes * create space ([#173](#173)) ([597240f](597240f)) * create space using the latest w3up-client version ([#171](#171)) ([600766b](600766b)) * **createSpace:** using the latest w3ui with w3up-client ([#176](#176)) ([5194dd2](5194dd2)) * gateway authorization based on env ([#174](#174)) ([0eb122d](0eb122d)) * set ipfs gateway url based on env var ([#177](#177)) ([1defed6](1defed6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to create new spaces in
Staging
orlocalhost
environments we need to configure the w3up-client to authorize the correct gateway service, otherwise, it will default to the Production Storacha Gateway.This PR implements the logic to create the gateway connection based on the environment variables and passes that connection to the
w3up-client.createSpace
call, so the correct service is authorized.