Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.redhat.com/browse/ACM-16183 #7361

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

dockerymick
Copy link
Contributor

No description provided.

@@ -92,6 +97,8 @@ spec:
- `disable-cert-rotation`
- `client-cert-name`
- `tls-min-version`
<5> Use the `config` section to exclude namespaces from certain processes for all constraints on your hub cluster.
<6> The supported values for the `disableDefaultMatches` parameter are `true` and `false`. When you set the parameter to `true` the namespaces are not added to `excludedNamespaces` in the `config` custom resource of the Gatekeeper operator.
Copy link
Contributor

@yiraeChristineKim yiraeChristineKim Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DisableDefaultMatches is a boolean parameter that disables appending the default exempt namespaces provided by the Gatekeeper Operator, typically related to OpenShift or Kubernetes system namespaces (e.g., openshift-node, openshift-dns). By default, this parameter is set to false, allowing the default namespaces (like openshift-*) to be appended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiraeChristineKim thanks for this! Is it important to mention what type of namespaces are expected? Are OpenShift or Kubernetes system namespaces the only supported values, or can users input different system namespaces?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hypershift", "hive", "rhacs-operator", "open-cluster-*", "openshift-*"

This is the list of namespaces we added by default. Mentioning this can help reduce user confusion.

@openshift-ci openshift-ci bot removed the lgtm label Jan 15, 2025
Copy link
Collaborator

@jc-berger jc-berger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dockerymick, jc-berger, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jan 17, 2025
Copy link

openshift-ci bot commented Jan 17, 2025

New changes are detected. LGTM label has been removed.

@dockerymick dockerymick merged commit d76042e into 2.13_stage Jan 21, 2025
1 of 2 checks passed
@dockerymick dockerymick deleted the mj-ACM-16183-213 branch January 21, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants