https://issues.redhat.com/browse/ACM-15276 BMH role #7359
Conversation
| <2> Replace with the name of your host. | ||
| <3> Possible values are `master` or `worker`. |
| <4> The name must match the name of your `InfrEnv` and exist in the same namespace. | ||
| <5> If you do not set a value, the `metadata` value is automatically used. | ||
| <6> Make sure the MAC address matches the MAC address of one of your host interfaces. | ||
| <7> Use the address of the BMC. See _Port access for the out-of-band management IP address_ for more information. |
There was a problem hiding this comment.
This looks really good. The only thing I would caution is that the user has to go search for this resource without any clues.
See section later in this topic? Or something.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carbonin, oafischer, swopebe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| ---- | ||
| bmac.agent-install.openshift.io/role: master | ||
| ---- | ||
|
|
There was a problem hiding this comment.
Thank you for taking care of the scaling parts!
We have to add the annotation when we create a BareMetalHost resource. We cannot add the annotation after creating it, because Agent resource is automatically approved and the node installation will be automatically completed.
And, setting the agent to master is required only when we're using discovery ISO method, not BareMetalHost.
I wrote my suggestion below. What do you think about it?
. Complete the steps in xref:scale_node_ocp.adoc#add-nodes-cim-ocp[Adding worker nodes to {ocp-short} clusters] for your the new control plane node.
If you are using a `BareMetalHost` to add a node, add the following line to your `BareMetalHost` annotations when creating the `BareMetalHost` resource:
+
[source,yaml]
----
bmac.agent-install.openshift.io/role: master
----
. If you are using discovery ISO to add a node, set the agent to `master` before you approve the agent by running the following command:
+
[source,bash]
----
oc patch agent <AGENT-NAME> -p '{"spec":{"role": "master"}}' --type=merge
----
+
*Note:* CSRs are not automatically approved.
Also for 2.12, 2.11 and 2.10.