Fix grafana dashboards update when adding new folder #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thibault Mange <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thibaultmg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Thibault Mange <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per documentation, sqlite needs access to a temporary directory for some operations. As the root file system is readOnly and it picks by default the
/tmpdir, adding a folder was failing since we upgraded Grafana.This PR adds a tempdir env variable for sqlite that point to the same mounted directory as the database as it is writable.
This PR also includes an improvement to reduce e2e test flakiness. Previously, because
cert/time-restartedonly had minute-level accuracy, it was possible for two e2e tests to generate the same timestamp, leaving components unchanged and causing tests to fail. The time accuracy is now improved, down to the second.