Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor update of README and Makefile #1763

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tremes
Copy link

@tremes tremes commented Jan 10, 2025

This is a minor update to the README link for installing kustomize and a minor update to the Makefile where the undeploy command does not seem to be correct.

I was also wondering if the mention of the kustomize goal in https://github.com/stolostron/multicluster-observability-operator/blob/main/operators/multiclusterobservability/Makefile should be removed, because it doesn't seem to be defined anywhere (and it's referenced in the install, uninstall and deploy goals)

Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tremes
Once this PR has been reviewed and has the lgtm label, please assign philipgough for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant