Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.12] [ACM-16335] Reconcile MCO only when there is actual change in mch image manifest #1728

Merged
merged 4 commits into from
Dec 17, 2024
Merged

[release-2.12] [ACM-16335] Reconcile MCO only when there is actual change in mch image manifest #1728

merged 4 commits into from
Dec 17, 2024

Conversation

openshift-cherrypick-robot
Copy link
Collaborator

This is an automated cherry-pick of #1719

/assign coleenquadros

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 17, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.8% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 17, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 85e88f3 link false /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

philipgough
philipgough approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@philipgough philipgough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, philipgough

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coleenquadros coleenquadros merged commit bc928a5 into stolostron:release-2.12 Dec 17, 2024
15 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

Assignees

@philipgough philipgough

@coleenquadros coleenquadros

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @philipgough @coleenquadros