update MCO cluster role for imagestreams #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coleenquadros
force-pushed
the
update_cluster_role
branch
from
fd6068e to
8edf748
Compare
coleenquadros
changed the title
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coleenquadros, philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
Signed-off-by: Coleen Iona Quadros <[email protected]>
coleenquadros
force-pushed
the
update_cluster_role
branch
from
70c5685 to
ab98bac
Compare
|
New changes are detected. LGTM label has been removed. |
JoaoBraveCoding
pushed a commit
to JoaoBraveCoding/multicluster-observability-operator
that referenced
this pull request
Sep 9, 2024
* update cluster role for imagestreams Signed-off-by: Coleen Iona Quadros <[email protected]> * update cluster role for imagestreams Signed-off-by: Coleen Iona Quadros <[email protected]> * update cluster role for imagestreams Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]>
JoaoBraveCoding
pushed a commit
to JoaoBraveCoding/multicluster-observability-operator
that referenced
this pull request
Sep 9, 2024
* update cluster role for imagestreams Signed-off-by: Coleen Iona Quadros <[email protected]> * update cluster role for imagestreams Signed-off-by: Coleen Iona Quadros <[email protected]> * update cluster role for imagestreams Signed-off-by: Coleen Iona Quadros <[email protected]> --------- Signed-off-by: Coleen Iona Quadros <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit for -> #1587
Since Cluster role is Managed by MCH. It needs to get updated here first. -> https://github.com/stolostron/multiclusterhub-operator/blob/main/pkg/templates/charts/toggle/multicluster-observability-operator/templates/multicluster-observability-operator-clusterrole.yaml
This is to prevent the MCO operator from failing to come up due to permission