update to deployer functions for AddOnDeploymentConfig and ClusterManagementAddOn #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest-required |
JoaoBraveCoding
force-pushed
the
deployer-fix
branch
from
be74f64 to
9d14c6b
Compare
ClusterManagementAddOn In stolostron#1470 we added support for deploying and configuring MCOA with the capabilities field. However if we enabled a field in capabilities and then disable it MCO would not reconcile the AddOnDeploymentConfig correctly due to DeepDerivative, that would return true instead of false. Signed-off-by: Joao Marcal <[email protected]>
JoaoBraveCoding
force-pushed
the
deployer-fix
branch
from
9d14c6b to
b18f7df
Compare
|
/retest-required |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest-required |
3 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/retest |
1 similar comment
|
/retest |
|
/retest-required |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
JoaoBraveCoding
force-pushed
the
deployer-fix
branch
from
eeee7c4 to
f9c64ea
Compare
Signed-off-by: Joao Marcal <[email protected]>
JoaoBraveCoding
force-pushed
the
deployer-fix
branch
from
f9c64ea to
5c41667
Compare
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoaoBraveCoding, periklis, philipgough The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1470 we added support for deploying and configuring MCOA with the capabilities field. However, if we enabled a field in capabilities and then disabled it MCO would not reconcile the AddOnDeploymentConfig correctly due to DeepDerivative, which would return true instead of false.