clean

Signed-off-by: Thibault Mange <[email protected]>

.github/workflows/metrics.yml

@@ -1,4 +1,4 @@
-name: check collected metrics
+name: collected metrics (MCOA)
 
 on:
   push:

cicd-scripts/metrics/README.md

@@ -13,22 +13,3 @@ More precisely, it helps verifying that:
 
 When adding a new list of dashboards in a new directory, make sure that you define the corresponding scrapeConfig and rules.
 Then add a target in the Makefile to run the metrics check for the new dashboards, following the existing examples.
-
-Generate metrics count stats:
-
-```bash
-./extract-dashboards-metrics.sh | tr '\n' ' ' | xargs ./count-metrics.sh > metrics-stats.txt
-```
-
-Sort extracted metrics to identify highest cardinality ones:
-
-```bash
-sort -k2,2nr metrics-stats.txt | grep -v " 0"
-```
-
-
-Check prom rules
-```bash
-cat grafana/nexus/acm/prometheus-rule.yaml | yq '.spec' | promtool check rules
-```
-

scripts/install-binaries.sh

@@ -7,7 +7,6 @@
 # If the binaries are already executable on the ${PATH} of the host, the script will skip the installation.
 # Each function takes a path as the first argument, which is the directory where the binary will be installed.
 # If no path is provided, fallback to ${BIN_DIR} or default path to /usr/local/bin.
-set -x
 KUBECTL_VERSION="${KUBECTL_VERSION:=v1.28.2}"
 JQ_VERSION="${JQ_VERSION:=1.7.1}"
 YQ_VERSION="${YQ_VERSION:=4.45.1}"