Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add qps and burst options #422

Merged
merged 1 commit into from
Nov 21, 2024
Merged

add qps and burst options #422

merged 1 commit into from
Nov 21, 2024

Conversation

zhiweiyin318
Copy link
Contributor

@xuezhaojun xuezhaojun closed this Nov 19, 2024
@xuezhaojun xuezhaojun reopened this Nov 19, 2024
@xuezhaojun xuezhaojun closed this Nov 20, 2024
@xuezhaojun xuezhaojun reopened this Nov 20, 2024
@xuezhaojun xuezhaojun requested a review from Copilot November 20, 2024 12:15
Copilot
Copilot AI reviewed Nov 20, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
@zhiweiyin318
add qps and burst options
baf1526 
Signed-off-by: Zhiwei Yin <[email protected]>
@zhiweiyin318
Copy link
Contributor Author

zhiweiyin318 commented Nov 21, 2024 •
edited
Loading

/assign @qiujian16
/assign @zhujian7

@zhujian7
Copy link
Contributor

/lgtm
/hold

@openshift-ci openshift-ci bot added the lgtm label Nov 21, 2024
@qiujian16
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, zhiweiyin318, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [zhiweiyin318,zhujian7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhiweiyin318
Copy link
Contributor Author

/unhold

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@openshift-merge-bot openshift-merge-bot bot merged commit 044af5d into stolostron:main Nov 21, 2024
9 checks passed
@zhiweiyin318 zhiweiyin318 deleted the add-qps branch November 21, 2024 12:42
@zhiweiyin318
Copy link
Contributor Author

/cherry-pick backplane-2.7

@openshift-cherrypick-robot
Copy link
Contributor

@zhiweiyin318: new pull request created: #448

In response to this:

/cherry-pick backplane-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

@qiujian16 qiujian16

@zhujian7 zhujian7

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhiweiyin318 @zhujian7 @qiujian16 @openshift-cherrypick-robot @xuezhaojun