Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Sync] Syncing #151 #517

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

JeffeyL
Copy link
Contributor

@JeffeyL JeffeyL commented Dec 12, 2023

This addresses #516

Previously, the E2E tests on PRs did not use ServiceAccounts, requiring manual updates for permissions for a code change. This change instead uses ServiceAccounts generated by Kubebuilder.

Ref: https://issues.redhat.com/browse/ACM-3299
Signed-off-by: Jeffrey Luo <[email protected]>
@JeffeyL JeffeyL changed the title Use the controller ServiceAccount for E2E tests [Manual Sync] Syncing #151 Dec 12, 2023
Copy link

openshift-ci bot commented Dec 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JeffeyL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@openshift-merge-bot openshift-merge-bot bot merged commit 18cf3ef into stolostron:main Dec 12, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants