Update PlacementBinding messages to use ns/name

Signed-off-by: Dale Haiducek <[email protected]> (cherry picked from commit 78839d2)
stolostron · Feb 15, 2024 · cede849 · cede849
1 parent 6d25754
commit cede849
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/controllers/common/common.go b/controllers/common/common.go
@@ -180,7 +180,7 @@ func GetDecisions(
 	ctx context.Context, c client.Client, pb *policiesv1.PlacementBinding,
 ) ([]appsv1.PlacementDecision, error) {
 	if !HasValidPlacementRef(pb) {
-		return nil, fmt.Errorf("placement binding %s/%s reference is not valid", pb.Name, pb.Namespace)
+		return nil, fmt.Errorf("placement binding %s/%s reference is not valid", pb.Namespace, pb.Name)
 	}
 
 	refNN := types.NamespacedName{
@@ -234,7 +234,7 @@ func GetDecisions(
 		return plr.Status.Decisions, nil
 	}
 
-	return nil, fmt.Errorf("placement binding %s/%s reference is not valid", pb.Name, pb.Namespace)
+	return nil, fmt.Errorf("placement binding %s/%s reference is not valid", pb.Namespace, pb.Name)
 }
 
 func ParseRootPolicyLabel(rootPlc string) (name, namespace string, err error) {

diff --git a/controllers/common/common_status_update.go b/controllers/common/common_status_update.go
@@ -70,7 +70,7 @@ func GetPolicyPlacementDecisions(ctx context.Context, c client.Client,
 	instance *policiesv1.Policy, pb *policiesv1.PlacementBinding,
 ) (decisions []appsv1.PlacementDecision, placements []*policiesv1.Placement, err error) {
 	if !HasValidPlacementRef(pb) {
-		return nil, nil, fmt.Errorf("placement binding %s/%s reference is not valid", pb.Name, pb.Namespace)
+		return nil, nil, fmt.Errorf("placement binding %s/%s reference is not valid", pb.Namespace, pb.Name)
 	}
 
 	policySubjectFound := false