-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ocm namespace in managed and hub #516
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77c2f47
to
de4255c
Compare
Ref: https://issues.redhat.com/browse/ACM-13609 Signed-off-by: yiraeChristineKim <[email protected]>
de4255c
to
a451b49
Compare
Quality Gate passedIssues Measures |
@@ -777,6 +786,44 @@ func getFreeLocalAddr() (string, error) { | |||
return fmt.Sprintf("127.0.0.1:%d", l.Addr().(*net.TCPAddr).Port), nil | |||
} | |||
|
|||
// createOcmNamespace create open-cluster-management-policies namespace | |||
// on the managedClusters and hubCluster for standalone policies | |||
func createOcmNamespace(mgrCtx context.Context, managedClient *rest.Config, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please use the addon controller instead like we do for the cluster namespace on the managed cluster?
https://github.com/open-cluster-management-io/governance-policy-addon-controller/blob/main/pkg/addon/policyframework/manifests/managedclusterchart/templates/namespace.yaml
Ref: https://issues.redhat.com/browse/ACM-13609