-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable hermetic builds #156
Conversation
884efae
to
dd368d3
Compare
/retest |
Signed-off-by: Dale Haiducek <[email protected]>
EC is still failing, but the hermetic-ness of the build is functioning, so this is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -29,6 +29,7 @@ LABEL name=gatekeeper/gatekeeper-operator-bundle | |||
LABEL description="The Gatekeeper Operator installs and configures Open Policy Agent Gatekeeper." | |||
LABEL summary="Red Hat Gatekeeper Operator" | |||
LABEL version=v3.17.1 | |||
LABEL release="0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiousity, what does this number track? Does it get automatically updated somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been looking into it. Currently it's just a meaningless requirement from EC. Apparently there have been discussions around it but nothing concrete, for example:
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.