Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hermetic builds #156

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Enable hermetic builds #156

merged 1 commit into from
Jan 27, 2025

Conversation

dhaiducek
Copy link

No description provided.

@dhaiducek
Copy link
Author

/retest

Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek
Copy link
Author

EC is still failing, but the hermetic-ness of the build is functioning, so this is ready for review.

Copy link

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -29,6 +29,7 @@ LABEL name=gatekeeper/gatekeeper-operator-bundle
LABEL description="The Gatekeeper Operator installs and configures Open Policy Agent Gatekeeper."
LABEL summary="Red Hat Gatekeeper Operator"
LABEL version=v3.17.1
LABEL release="0"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiousity, what does this number track? Does it get automatically updated somewhere?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been looking into it. Currently it's just a meaningless requirement from EC. Apparently there have been discussions around it but nothing concrete, for example:

Copy link

openshift-ci bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 81f7a02 into release-3.17 Jan 27, 2025
7 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the hermetic branch January 27, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants