Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACM-15128 networking options support for node pools HCP cluster #4183

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
c342202
adds networking support for nodepools
vishsanghishetty Jan 7, 2025
4f674d1
adds networking support for nodepools
vishsanghishetty Jan 8, 2025
3c40824
adds networking support for nodepools
vishsanghishetty Jan 8, 2025
23c2f3d
adds networking support for nodepools
vishsanghishetty Jan 8, 2025
a6f3598
adds networking support for nodepools tests
vishsanghishetty Jan 8, 2025
b383116
adds networking support for nodepools tests and snapshot
vishsanghishetty Jan 8, 2025
ad5e451
addresses sonar issues
vishsanghishetty Jan 9, 2025
74ca285
merges main
vishsanghishetty Jan 14, 2025
8bddf89
handlebar template kubevirt
vishsanghishetty Jan 14, 2025
708f82a
controldata kubevirt
vishsanghishetty Jan 14, 2025
a77137a
control data helper function kubevirt
vishsanghishetty Jan 14, 2025
202f9d5
tests snapshot kubevirt
vishsanghishetty Jan 14, 2025
5bba312
validation kubernetes name kubevirt
vishsanghishetty Jan 14, 2025
48936ca
additional networks kubevirt cluster creation tests
vishsanghishetty Jan 14, 2025
0bd8d09
translation strings kubevirt
vishsanghishetty Jan 14, 2025
7ae2f2d
translation strings kubevirt
vishsanghishetty Jan 14, 2025
fd3b525
sonar issues
vishsanghishetty Jan 14, 2025
e3762b2
updates tests snapshot
vishsanghishetty Jan 14, 2025
f4fffc8
updates translations
vishsanghishetty Jan 16, 2025
786bc2f
updates initialize control with cloneDeep
vishsanghishetty Jan 16, 2025
a2364f6
john's fix for scrollbar issue
vishsanghishetty Jan 16, 2025
711dccf
updates translations
vishsanghishetty Jan 16, 2025
93f45ef
updates kubevirt cluster creation tests with networking support for n…
vishsanghishetty Jan 16, 2025
ad552ea
implements update default pod network function
vishsanghishetty Jan 16, 2025
620a40c
implements additional networks for node pools
vishsanghishetty Jan 16, 2025
5e9a3e3
updates tests snapshot
vishsanghishetty Jan 16, 2025
3a83199
updates tests snapshot
vishsanghishetty Jan 21, 2025
00391d8
updates handlebar template
vishsanghishetty Jan 21, 2025
2ea8b0d
validation functions updates
vishsanghishetty Jan 21, 2025
5e2c258
validation functions updates
vishsanghishetty Jan 21, 2025
fda6db2
validation function updates tests
vishsanghishetty Jan 21, 2025
728a761
updates translations and format
vishsanghishetty Jan 21, 2025
5893120
updates Kubevirt cluster creation tests
vishsanghishetty Jan 21, 2025
ec03290
updates translations
vishsanghishetty Jan 21, 2025
7c2a539
updates initialize control data
vishsanghishetty Jan 21, 2025
4f3ff8d
prettier fix
vishsanghishetty Jan 21, 2025
ee0f1f1
updates translations
vishsanghishetty Jan 22, 2025
2bf6d74
updates translations and Kevin's suggestions
vishsanghishetty Jan 22, 2025
4400226
updates translations and tests snapshot
vishsanghishetty Jan 22, 2025
2122110
updates translations and tests snapshot
vishsanghishetty Jan 22, 2025
4c21fc2
updates translations
vishsanghishetty Jan 22, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions frontend/public/locales/en/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@
"add": "Add",
"Add": "Add",
"Add a search constraint": "Add a search constraint",
"Add additional network": "Add additional network",
"Add another time range": "Add another time range",
"Add Argo Server": "Add Argo Server",
"Add claim expression": "Add claim expression",
Expand Down Expand Up @@ -416,6 +417,7 @@
"Adding hosts allows cluster creators to pull any available hosts from the infrastructure environment.": "Adding hosts allows cluster creators to pull any available hosts from the infrastructure environment.",
"Additional actions": "Additional actions",
"Additional information:": "Additional information:",
"Additional networks": "Additional networks",
"Additional providers": "Additional providers",
"Additional trust bundle": "Additional trust bundle",
"Advanced configuration": "Advanced configuration",
Expand Down Expand Up @@ -522,6 +524,7 @@
"Argo server": "Argo server",
"Argo Server exposes an API and UI for workflows. You can run this in either \"hosted\" or \"local\" mode. ": "Argo Server exposes an API and UI for workflows. You can run this in either \"hosted\" or \"local\" mode. ",
"ArgoCD": "ArgoCD",
"Attach default pod network": "Attach default pod network",
"Attempts to delete all of the objects related to the deleted policy.": "Attempts to delete all of the objects related to the deleted policy.",
"Attempts to delete objects known to be created by the policy when the policy is deleted.": "Attempts to delete objects known to be created by the policy when the policy is deleted.",
"Attribute filters": "Attribute filters",
Expand Down Expand Up @@ -790,6 +793,7 @@
"Configure external infrastructure for OpenShift Virtualization": "Configure external infrastructure for OpenShift Virtualization",
"Configure host inventory settings": "Configure host inventory settings",
"Configure network access for your cluster. One network is created by default.": "Configure network access for your cluster. One network is created by default.",
"Configure networking options for your nodepool": "Configure networking options for your nodepool",
"confirm": "confirm",
"Conflict": "Conflict",
"Connect your cloud provider": "Connect your cloud provider",
Expand Down Expand Up @@ -1304,6 +1308,7 @@
"Enter search text": "Enter search text",
"Enter skip tag with \",\" or \"enter\"": "Enter skip tag with \",\" or \"enter\"",
"Enter Storage Class": "Enter Storage Class",
"Enter the additional network in the format <namespace>/<name>": "Enter the additional network in the format <namespace>/<name>",
"Enter the Amazon Web Services credentials": "Enter the Amazon Web Services credentials",
"Enter the Ansible Automation Platform credentials": "Enter the Ansible Automation Platform credentials",
"Enter the Ansible Tower host URL": "Enter the Ansible Tower host URL",
Expand Down Expand Up @@ -1878,11 +1883,13 @@
"Name": "Name",
"Name needs to be unique to the namespace on each of the managed clusters.": "Name needs to be unique to the namespace on each of the managed clusters.",
"Name your search and provide a description so that you can access it in the future.": "Name your search and provide a description so that you can access it in the future.",
"name.invalid.dns.label": "The name is invalid. $t(import.form.invalid.dns.label)",
"namespace": "namespace",
"Namespace": "Namespace",
"Namespace where the selected Argo application resources are deployed.": "Namespace where the selected Argo application resources are deployed.",
"Namespace: {{namespace}}": "Namespace: {{namespace}}",
"namespace.exists.error": "The namespace you selected is already used by an existing managed cluster.",
"namespace.invalid.dns.label": "The namespace is invalid. $t(import.form.invalid.dns.label)",
"Namespaces": "Namespaces",
"Namespaces match label expressions": "Namespaces match label expressions",
"Namespaces match labels": "Namespaces match labels",
Expand All @@ -1892,6 +1899,7 @@
"Network error": "Network error",
"Network Optimized": "Network Optimized",
"Networking": "Networking",
"Networking options": "Networking options",
"New placement": "New placement",
"New template": "New template",
"New version": "New version",
Expand Down Expand Up @@ -3014,6 +3022,7 @@
"tooltip.creation.app.reconcileRate": "The frequency of resource reconciliation that is used as a global repository setting. The medium default setting checks for changes to apply every three minutes and re-applies all resources every 15 minutes, even without a change. Select low to reconcile every hour. Select high to reconcile every two minutes. If you select off, the deployed resources are not automatically reconciled.",
"tooltip.creation.app.settings.existingRule": "If available in the application namespace, you can select a predefined placement configuration",
"tooltip.creation.app.subReconcileRate": "Turn the auto-reconciliation off for this specific application regardless of the reconcile rate setting in the repository.",
"tooltip.creation.nodepool.additional.network": "The name specifies the network attached to the nodes in the format <namespace>/<name> to reference the multus network attachment definition",
"tooltip.creation.ocp.api.vip": "The Virtual IP to use for internal API communication. The DNS must be preconfigured with an A/AAAA or CNAME record so the api.<cluster name>.<Base DNS domain> path resolves correctly.",
"tooltip.creation.ocp.aws.instance.type": "The EC2 instance type for your compute machines.",
"tooltip.creation.ocp.aws.region": "The AWS region where the installation program creates your cluster resources. You can select zones within the region for your control plane and worker pools.",
Expand Down Expand Up @@ -3047,6 +3056,7 @@
"tooltip.creation.ocp.name": "The unique name of your cluster. The value must be a string that contains lowercase alphanumeric values, such as dev. Cannot be changed after creation.",
"tooltip.creation.ocp.node.pool.autorepair": "Enables machine auto-repair with machine health checks",
"tooltip.creation.ocp.node.pool.core.count": "Number of cores assigned to each worker node VM",
"tooltip.creation.ocp.node.pool.default.pod.network": "Check this box to attach the default pod network to nodes from this pool.",
"tooltip.creation.ocp.node.pool.memoryGB": "Memory assigned to each worker node VM",
"tooltip.creation.ocp.node.pool.name": "The unique name of your node pool. The value must be a string that contains lowercase alphanumeric values, such as dev. Cannot be changed after creation.",
"tooltip.creation.ocp.node.pool.replica.count": "The number of Worker Nodes in the cluster",
Expand Down Expand Up @@ -3200,6 +3210,7 @@
"validation.missing.value": "{{0}} is required",
"Value": "Value",
"Value must be a valid IPv4 CIDR.": "Value must be a valid IPv4 CIDR.",
"Value must be in <namespace>/<name> format.": "Value must be in <namespace>/<name> format.",
"Value must be integer greater than": "Value must be integer greater than {{0}}.",
"values": "values",
"Values": "Values",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/components/TemplateEditor/TemplateEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ export default class TemplateEditor extends React.Component {
</DrawerPanelContent>
}
>
<DrawerContentBody>
<DrawerContentBody style={{ height: '100%' }}>
<PageSection isFilled type="wizard" style={{ height: '100%' }}>
{this.renderControls(isLoaded)}
</PageSection>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* Copyright Contributors to the Open Cluster Management project */
'use strict'

import { cloneDeep } from 'lodash'
import get from 'lodash/get'

///////////////////////////////////////////////////////////////////////////////
Expand Down Expand Up @@ -52,7 +53,17 @@ export const initializeControlData = (initialControlData, onControlInitialize, i
const initialControl = (control, onControlInitialize) => {
const { type, isInitialized } = control
if (!isInitialized) {
let controlData
let active
if (control.controlData) {
controlData = cloneDeep(control.controlData)
active = cloneDeep(control.active)
}
control = Object.assign({}, control)
if (controlData) {
control.controlData = controlData
control.active = active
}

// initialize control's active value
initializeControlActive(type, control)
Expand Down
Loading