Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCC V2 privileged and ro root filesystem #539

Merged
merged 1 commit into from
Oct 18, 2023
Merged

SCC V2 privileged and ro root filesystem #539

merged 1 commit into from
Oct 18, 2023

Conversation

ngraham20
Copy link
Contributor

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2
/cc @dislbenn @joeg-pro

@openshift-ci openshift-ci bot requested review from dislbenn and joeg-pro October 17, 2023 22:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dislbenn
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, ngraham20

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit ecd3af2 into stolostron:main Oct 18, 2023
3 checks passed
ngraham20 added a commit that referenced this pull request Oct 18, 2023
@ngraham20
Revert "SCC V2 privileged and ro root filesystem (#539)"
98f230d 
This reverts commit ecd3af2.
@ngraham20 ngraham20 mentioned this pull request Oct 18, 2023
Closed
ngraham20 pushed a commit to ngraham20/backplane-operator that referenced this pull request Oct 18, 2023
Revert "SCC V2 privileged and ro root filesystem (stolostron#539)"
4b92669 
This reverts commit ecd3af2.
Signed-off-by: Nathaniel Graham <[[email protected], [email protected]]>
openshift-ci bot pushed a commit that referenced this pull request Oct 18, 2023
@ngraham20
Revert "SCC V2 privileged and ro root filesystem (#539)" (#541)
c445245 
This reverts commit ecd3af2.
Signed-off-by: Nathaniel Graham <[[email protected], [email protected]]>

Co-authored-by: Nathaniel Graham <[[email protected], [email protected]]>
@ngraham20 ngraham20 deleted the secv2 branch April 2, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dislbenn dislbenn Awaiting requested review from dislbenn

@joeg-pro joeg-pro Awaiting requested review from joeg-pro

Assignees

@dislbenn dislbenn

Labels
approved dco-signoff: yes do-not-merge/work-in-progress lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngraham20 @dislbenn