Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permissions for clusterlifecycle state metrics #1175

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

zhujian7
Copy link
Contributor

@zhujian7 zhujian7 commented Jan 6, 2025

Description

Please provide a brief description of the purpose of this pull request.

clusterlifecycle state metrics needs these permissions to start a controller to add the observed first applied timestamp for manifestworks.
see PR stolostron/clusterlifecycle-state-metrics#215

Related Issue

https://issues.redhat.com/browse/ACM-16796

If applicable, please reference the issue(s) that this pull request addresses.

Changes Made

Provide a clear and concise overview of the changes made in this pull request.

Screenshots (if applicable)

Add screenshots or GIFs that demonstrate the changes visually, if relevant.

Checklist

  • I have tested the changes locally and they are functioning as expected.
  • I have updated the documentation (if necessary) to reflect the changes.
  • I have added/updated relevant unit tests (if applicable).
  • I have ensured that my code follows the project's coding standards.
  • I have checked for any potential security issues and addressed them.
  • I have added necessary comments to the code, especially in complex or unclear sections.
  • I have rebased my branch on top of the latest main/master branch.

Additional Notes

Add any additional notes, context, or information that might be helpful for reviewers.

Reviewers

Tag the appropriate reviewers who should review this pull request. To add reviewers, please add the following line: /cc @reviewer1 @reviewer2

Definition of Done

  • Code is reviewed.
  • Code is tested.
  • Documentation is updated.
  • All checks and tests pass.
  • Approved by at least one reviewer.
  • Merged into the main/master branch.

Copy link

sonarqubecloud bot commented Jan 6, 2025

@zhujian7
Copy link
Contributor Author

zhujian7 commented Jan 6, 2025

/assign @qiujian16 @elgnay @dislbenn

@dislbenn
Copy link
Collaborator

dislbenn commented Jan 6, 2025

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dislbenn, zhujian7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit dd198ce into stolostron:main Jan 6, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants