fix: use a growable bloom filter implementation. #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the fast bloom filter implementation with a growable one.
A growable implementation is required as the bloom filter is used within a
generator; the number of elements in the bloom filter is unbounded and
dependent upon how many docker tasks are spawned rather than how many docker
tasks may spawn concurrently.
Included with these changes:
thiserror
for custom error types (the crate was already a transitivedependency).
Option<NonEmpty<C>>
where C is a collection type with thecollection type itself; this makes the API more ergonomic.
args
inExecution
withprogram
andargs
; this makes the API alittle less confusing as not everything is put into
args
. The nameprogram
was chosen as that's whatstd::process::Command::new
uses.builder.rs
files.Engine
and tracking tasks fromRunner
tomake it
Send+Sync
. The UI is moved into relevantmain.rs
files.Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md
(see"keep a changelog" for more information).