Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve docs/spec.md #6

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

64J0
Copy link
Contributor

@64J0 64J0 commented Mar 19, 2024

Description:

With this PR, I'm improving a bit the text on docs/spec.md and adding a new advanced example, featuring a complete fsx script showing how to validate an e-mail based on .NET docs (reference link was added there as well).

@64J0 64J0 changed the title Improve docs/spec.md chore: improve docs/spec.md Mar 19, 2024
Copy link
Owner

@stijnmoreels stijnmoreels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this is great. Thx a lot!

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.20%. Comparing base (5e6cf6e) to head (9e32d37).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
+ Coverage   85.02%   85.20%   +0.17%     
==========================================
  Files           4        4              
  Lines         561      561              
  Branches       59       59              
==========================================
+ Hits          477      478       +1     
  Misses         58       58              
+ Partials       26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stijnmoreels stijnmoreels merged commit 54f3299 into stijnmoreels:main Mar 20, 2024
5 checks passed
@64J0 64J0 deleted the 64J0-patch-1 branch March 20, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants