Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SOCKS4 support. #38

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Added SOCKS4 support. #38

merged 8 commits into from
Jun 18, 2024

Conversation

RoKu1
Copy link
Contributor

@RoKu1 RoKu1 commented Jun 16, 2024

Supports: #39
SOCKS4 support with and without userid.
Both Connect and Bind supported.
RFC Followed: SOCKS4 RFC

@RoKu1
Copy link
Contributor Author

RoKu1 commented Jun 16, 2024

Hi @sticnarf , this is a complete socks4 support addition, with both Connect and Bind. Also, additionally UserID support is added. Code is organised as per existing flow, and separated out in a new file to avoid confusion.

@RoKu1 RoKu1 changed the title Added SOCKS4 support. Added SOCKS4 support. Supports: #39 Jun 17, 2024
@RoKu1 RoKu1 changed the title Added SOCKS4 support. Supports: #39 Added SOCKS4 support. Jun 17, 2024
Copy link
Owner

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I just fixed the broken Github Action. Can you please rebase so we can give it a test on CI again?

Copy link
Owner

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks.

@sticnarf sticnarf merged commit f1eac4f into sticnarf:master Jun 18, 2024
3 checks passed
@svix-jplatte svix-jplatte mentioned this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants