-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SOCKS4 support. #38
Conversation
Hi @sticnarf , this is a complete socks4 support addition, with both Connect and Bind. Also, additionally UserID support is added. Code is organised as per existing flow, and separated out in a new file to avoid confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I just fixed the broken Github Action. Can you please rebase so we can give it a test on CI again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks.
Supports: #39
SOCKS4 support with and without userid.
Both
Connect
andBind
supported.RFC Followed: SOCKS4 RFC