Skip to content

Commit

Permalink
remove stale checksum check in standard xrootd
Browse files Browse the repository at this point in the history
  • Loading branch information
root committed Feb 13, 2024
1 parent c3ac3ad commit 0eb1e67
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Binary file added packaging/xrootd-5.5.4-7.el7.src.rpm
Binary file not shown.
10 changes: 5 additions & 5 deletions src/XrdCks/XrdCksManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,8 @@ int XrdCksManager::Del(const char *Pfn, XrdCksData &Cks)
int XrdCksManager::Get(const char *Pfn, XrdCksData &Cks)
{
XrdOucXAttr<XrdCksXAttr> xCS;
time_t MTime;
// not checking stale checksums as ceph file modification times constantly refresh on read
//time_t MTime;
int rc, nFault;

// Determine which checksum to get (we will accept unsupported ones as well)
Expand All @@ -473,13 +474,12 @@ int XrdCksManager::Get(const char *Pfn, XrdCksData &Cks)
Cks = xCS.Attr.Cks;

// Verify the file
//
if ((rc = ModTime(Pfn, MTime))) return rc;
// not done as ceph mod times are weird
// if ((rc = ModTime(Pfn, MTime))) return rc;

// Return result
//
return (Cks.fmTime != MTime || nFault
|| Cks.Length > XrdCksData::ValuSize || Cks.Length <= 0
return ( nFault || Cks.Length > XrdCksData::ValuSize || Cks.Length <= 0
? -ESTALE : int(Cks.Length));
}

Expand Down

0 comments on commit 0eb1e67

Please sign in to comment.