Fix locales within container #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-green-stfc
approved these changes
Oct 9, 2024
|
This is going to fail on the end to end amphora test as the build clones the main branch of the repo |
This was previously cloning the latest main branch in the repo, instead of the contents of a fork or branch. As we're going to have the changes we intent to test, update build.sh to pull in the repo as-is
This was effectively ignoring our build script, which correctly made sure the paths lined up, and doesn't reflect how we actually run it. Below this is the correct version which re-built the image anyway
DavidFair
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the locale issue within the stripped out docker container