add manila and certmanager chart #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably fine to add chart now and we can remove them later if we find a better way to do this |
deploys cert-manager with extra cluster-issuers for lets-encrypt and a self-signed issuer
installs manila csi chart with a storage class builtin
anish-mudaraddi
force-pushed
the
add-anciliary-charts
branch
from
3a3a4c2 to
44fcad8
Compare
Dmitry-Popovichev
previously approved these changes
Jan 27, 2025
anish-mudaraddi
force-pushed
the
add-anciliary-charts
branch
from
44fcad8 to
ab1e548
Compare
Dmitry-Popovichev
previously approved these changes
Jan 28, 2025
anish-mudaraddi
force-pushed
the
add-anciliary-charts
branch
from
8f38a1e to
a4a823c
Compare
add prefix stfc-cloud so to emphasise that differentiate these charts to the upstream equivalent. So as to not confuse users These charts set up opinionated values/CRDs of the upstream chart
anish-mudaraddi
force-pushed
the
add-anciliary-charts
branch
from
a4a823c to
2d5738b
Compare
set to upstream chart "cert-manager"
gmatthews20
requested changes
Jan 28, 2025
charts/stfc-cloud-cert-manager/templates/le-prod-clusterissuer.yaml
Outdated
Show resolved
Hide resolved
otherwise we'll get all the emails for users by default!
anish-mudaraddi
force-pushed
the
add-anciliary-charts
branch
from
4e5976d to
af47134
Compare
now user provides a clouds.yaml when installing the chart instead of needing to specify another secret for manila to access openstack post-installation
with instructions on how to install
gmatthews20
approved these changes
Jan 28, 2025
Dmitry-Popovichev
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra charts - cert-manager and manila-csi and basically copying the upstream chart and creating small extra k8s resources
We'll likely only use these for use in for our internal clusters - cloud-deployed-apps - so it feels like there's a better way to do this - perhaps using kustomize? submitting as a draft