Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Notebook with both pytorch and tensorflow #99

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

meoflynn
Copy link
Contributor

@meoflynn meoflynn commented Jan 17, 2025

Description:

New notebook where it installs both pytorch and tensorflow into the image


Submitter:

Have you done the following?:

  • Added a new directory in the project root with a Dockerfile inside?
  • Tested the image works?

Reviewer:

Have you done the following?:

  • Does the Dockerfile install only the necessary packages?
  • Are the permissions of downloaded files onto the container appropriate?
  • Does the Dockerfile switch to NB_UID at the end of the file? (i.e the image is run as user, not root)
  • Has the image been built successfully and pushed to Harbor?

Adds a notebook where both pytorch and tensorflow are installed
@meoflynn meoflynn added the enhancement New feature or request label Jan 17, 2025
@meoflynn meoflynn marked this pull request as ready for review January 17, 2025 12:13
@khalford khalford merged commit 98daaa1 into master Jan 17, 2025
24 of 26 checks passed
@khalford khalford deleted the tf-pytorch-image branch January 17, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants