Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes Config #83

Merged
merged 11 commits into from
Dec 10, 2024
Merged

Kubernetes Config #83

merged 11 commits into from
Dec 10, 2024

Conversation

khalford
Copy link
Member

@khalford khalford commented Nov 29, 2024

Description:

Changes so we can also deploy with Kubernetes:

Kubernetes can't mount a configmap and secrets to the same directory. separating them so we can deploy with kubernetes.
Adds a deployment.yml to deploy onto a cluster

As the secrets location is changing this is a major change. All existing ChatOps instances will break and require re-deployment


Submitter:

Have you done the following?:

  • Labeled the pull request from the following? major | minor | patch or documentation | workflow
  • Updated the documentation and template config files?
  • Added unit tests for new / untested code?
  • Verified the relevant staging Docker image runs on dev-cloud-chatops.nubes.rl.ac.uk?

New / Existing features:

  • Written integration tests?
  • Configured the Slack Application with new commands or permission scope changes?
  • Updated the version.txt and docker-compose.yml files?

Reviewer:

Have you checked the following?:

  • Version change is appropriate to the code changes? Semantic versioning documentation here
  • Unit test code coverage is acceptable?
  • Do the CI jobs pass?

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.49%. Comparing base (54c30b3) to head (2a5a4d1).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
cloud-chatops/src/read_data.py 88.88% 2 Missing ⚠️
cloud-chatops/src/features/pr_reminder.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
- Coverage   96.52%   96.49%   -0.04%     
==========================================
  Files          13       13              
  Lines         634      627       -7     
==========================================
- Hits          612      605       -7     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Kubernetes can't mount a configmap and secrets to the same directory. separating them so we can deploy with kubernetes.
Update documentation to reflect this
Update major version as now secret path has changed it will break all existing deployments
This deployment will run a single pod of the chatops application. Requires a config map and secret to be created. Instructions on how to do that are updated into the documentation
@khalford khalford added the major SemVer major change label Nov 29, 2024
@khalford
Copy link
Member Author

Ignore codecov failing as those lines don't have tests in the first place. Therefore the coverage diff is really 0%

@khalford khalford marked this pull request as ready for review November 29, 2024 12:10
@khalford khalford marked this pull request as draft December 2, 2024 11:01
@khalford khalford marked this pull request as ready for review December 2, 2024 13:35
@khalford khalford requested review from a team, Neonbluestoplight and RJaliliSTFC December 2, 2024 13:35
RJaliliSTFC
RJaliliSTFC previously approved these changes Dec 2, 2024
@khalford khalford marked this pull request as draft December 4, 2024 09:36
Change the way the config user map is formatted.  Now it's a list of users information which is translated into a dataclass. This makes it easier to search the list of specific attributes than keys and values
@khalford khalford marked this pull request as ready for review December 9, 2024 12:00
@khalford khalford requested review from a team, RWhiting78 and DaveW-STFC and removed request for Neonbluestoplight December 9, 2024 12:01
@khalford khalford removed the request for review from DaveW-STFC December 9, 2024 12:02
@khalford khalford merged commit 6512a31 into master Dec 10, 2024
11 checks passed
@khalford khalford deleted the chatops-kubernetes branch December 10, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major SemVer major change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants