-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes Config #83
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
==========================================
- Coverage 96.52% 96.49% -0.04%
==========================================
Files 13 13
Lines 634 627 -7
==========================================
- Hits 612 605 -7
Misses 22 22 ☔ View full report in Codecov by Sentry. |
Kubernetes can't mount a configmap and secrets to the same directory. separating them so we can deploy with kubernetes. Update documentation to reflect this
Update major version as now secret path has changed it will break all existing deployments
This deployment will run a single pod of the chatops application. Requires a config map and secret to be created. Instructions on how to do that are updated into the documentation
b6dd259
to
4115d7c
Compare
Ignore codecov failing as those lines don't have tests in the first place. Therefore the coverage diff is really 0% |
Using YAML instead of JSON as it is easier to work with K8s and Helm
Change the way the config user map is formatted. Now it's a list of users information which is translated into a dataclass. This makes it easier to search the list of specific attributes than keys and values
4cbec10
to
31d1362
Compare
Description:
Changes so we can also deploy with Kubernetes:
Kubernetes can't mount a configmap and secrets to the same directory. separating them so we can deploy with kubernetes.
Adds a
deployment.yml
to deploy onto a clusterAs the secrets location is changing this is a major change. All existing ChatOps instances will break and require re-deployment
Submitter:
Have you done the following?:
major | minor | patch
ordocumentation | workflow
dev-cloud-chatops.nubes.rl.ac.uk
?New / Existing features:
version.txt
anddocker-compose.yml
files?Reviewer:
Have you checked the following?: