Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pr reminder v2 #82

Merged
merged 23 commits into from
Nov 29, 2024
Merged

Refactor pr reminder v2 #82

merged 23 commits into from
Nov 29, 2024

Conversation

khalford
Copy link
Member

@khalford khalford commented Nov 28, 2024

Description:

Rewrite of PR reminder feature:
Merged pr_reminder.py, post_to_dms.py and base_feature.py into one module. The base feature class is not needed anymore as future features will not be inheriting any methods from it, therefore it makes sense to remove it.


Submitter:

Have you done the following?:

  • Labeled the pull request from the following? major | minor | patch or documentation | workflow
  • Updated the documentation and template config files?
  • Added unit tests for new / untested code?
  • Verified the relevant staging Docker image runs on dev-cloud-chatops.nubes.rl.ac.uk?

New / Existing features:

  • Written integration tests?
  • Configured the Slack Application with new commands or permission scope changes?
  • Updated the version.txt and docker-compose.yml files?

Reviewer:

Have you checked the following?:

  • Version change is appropriate to the code changes? Semantic versioning documentation here
  • Unit test code coverage is acceptable?
  • Do the CI jobs pass?

@khalford khalford added the minor Semver minor change label Nov 28, 2024
@khalford khalford mentioned this pull request Nov 28, 2024
No need to reuse this code as it only occurs twice
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 98.98649% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.52%. Comparing base (1ebec0e) to head (7be42ac).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
cloud-chatops/tests/test_pr_reminder.py 97.72% 2 Missing ⚠️
cloud-chatops/tests/test_find_prs.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   94.97%   96.52%   +1.55%     
==========================================
  Files          19       13       -6     
  Lines         776      634     -142     
==========================================
- Hits          737      612     -125     
+ Misses         39       22      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@anish-mudaraddi anish-mudaraddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - had a chat with @khalford for how to refactor this code for extensibility so that would be the next step as we extend this to look at gitlab or send messages to places other than slack

@anish-mudaraddi anish-mudaraddi merged commit 54c30b3 into master Nov 29, 2024
11 checks passed
@khalford khalford deleted the refactor_pr_reminder_v2 branch December 10, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Semver minor change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants