Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pr reminder #79

Closed
wants to merge 15 commits into from
Closed

Refactor pr reminder #79

wants to merge 15 commits into from

Conversation

khalford
Copy link
Member

Rewrite of PR reminder. No longer going to use base feature as other features (such as collect effort upcoming) will not be using any methods from base feature.

@khalford khalford added the patch Semver patch change label Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 97.19626% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.03%. Comparing base (fe0e2b2) to head (52da350).

Files with missing lines Patch % Lines
cloud-chatops/src/events.py 71.42% 6 Missing ⚠️
cloud-chatops/tests/test_pr_reminder.py 97.72% 2 Missing ⚠️
cloud-chatops/tests/test_find_prs.py 97.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   96.25%   94.03%   -2.23%     
==========================================
  Files          19       13       -6     
  Lines         802      553     -249     
==========================================
- Hits          772      520     -252     
- Misses         30       33       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@khalford khalford closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Semver patch change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant